elastic / beats

:tropical_fish: Beats - Lightweight shippers for Elasticsearch & Logstash
https://www.elastic.co/products/beats
Other
96 stars 4.92k forks source link

[Security Integrations] Deprecating RSA2ELK Filebeat Modules #36125

Closed jamiehynds closed 1 year ago

jamiehynds commented 1 year ago

Several Filebeat modules which were originally converted from open source RSA parsers, are still under technical preview. Many of these modules have been rewritten as Elastic Agent integrations. These modules should be deprecated on the Filebeat side, to avoid users running sub-par, technical preview integrations, especially where better options exist via agent integrations.

To discuss: how does deprecation work? Is it similar to agent integrations where we can add a deprecation notice to each module? Can we remove this modules from future Stack releases? If we stop shipping these modules, will existing users of these modules still be able to use them?

Modules to deprecate:

elasticmachine commented 1 year ago

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

taylor-swanson commented 1 year ago

Since I recently handled an SDH involving one of these modules (sonicwall), I have an interest in working on this.

There's an existing example of a deprecated module, misp. It has a notice in its readme declaring that the module is deprecated:

deprecated::[7.14.0,"This module is deprecated. Use the <<filebeat-module-threatintel,Threat Intel module>> instead."]

https://github.com/elastic/beats/blob/main/x-pack/filebeat/module/misp/_meta/docs.asciidoc?plain=1#L8

It points to a different module as a way forward, but in other cases, it could point to a Fleet package (this is the case with sonicwall).

In most cases, the deprecated module has been superseded by a Fleet package. @jamiehynds, I haven't looked closely at this list yet, but I imagine we want to point users towards the Fleet package? Would there be any cases where an existing, non-deprecated module would be an option (similar to what is seen in the misp package)?

taylor-swanson commented 1 year ago

Here's a summary for the paths forward for the packages:

jamiehynds commented 1 year ago

Thanks for working through this @taylor-swanson - totally agree on pointing users to our agent integrations where applicable. In cases where there isn't an integration, we can recommend one of the Custom packages to at least ingest the data, and raise an issue in our integrations repo to request support for an integration.

List above looks good, just some minor tweaks.

taylor-swanson commented 1 year ago

Thanks, @jamiehynds! I updated the list above accordingly.

ebeahan commented 1 year ago

totally agree on pointing users to our agent integrations where applicable. In cases where there isn't an integration, we can recommend one of the Custom packages to at least ingest the data, and raise an issue in our integrations repo to request support for an integration.

@jamiehynds - @taylor-swanson and I were discussing, and @taylor-swanson shared the idea of a dedicated "deprecated integration" page somewhere in our docs. The page would provide a single place capturing the guidance you listed here (direct users how to use the custom package to replace a deprecated integration, direct users to open an issue in the integrations repo, etc.). Deprecated integrations could then link to it.

WDYT?

andrewkroh commented 1 year ago

@jamiehynds @taylor-swanson Is there a timeline for full removal of the deprecated modules? I want to mark my calendar ~so I can celebrate~ so we don't forget. 📆

jamiehynds commented 1 year ago

@jamiehynds @taylor-swanson Is there a timeline for full removal of the deprecated modules? I want to mark my calendar ~so I can celebrate~ so we don't forget. 📆

I'd suggest we aim for 8.14 for full removal, so that gives customers ~6 months notice.