elastic / beats

:tropical_fish: Beats - Lightweight shippers for Elasticsearch & Logstash
https://www.elastic.co/products/beats
Other
12.13k stars 4.91k forks source link

OSS filebeat harvester_test.go should not depend on Elastic-licensed code #40293

Closed andrewkroh closed 17 hours ago

andrewkroh commented 1 month ago

There a depguard lint rule failing because we have OSS test code depending on Elastic-licensed code from the x-pack/ directory. Due to licensing, dependencies are only allowed in the opposite direction. The code in question is test code so it doesn't taint any of our OSS release artifacts. Nonetheless, we should fix it (perhaps by moving the helper code from x-pack to oss).

filebeat/input/filestream/internal/input-logfile/harvester_test.go:36:2: import 'github.com/elastic/beats/v7/x-pack/dockerlogbeat/pipelinemock' is not allowed from list 'apache-licensed-code': Apache 2.0 licensed code cannot depend on Elastic licensed code (x-pack/). (depguard)

Related

botelastic[bot] commented 1 month ago

This issue doesn't have a Team:<team> label.

violetguos commented 1 month ago

Hi, can I take this issue? thanks

andrewkroh commented 1 month ago

Yes, please do. Thanks