[filebeat][gcs] - Simplified state checkpoint calculation

elastic / beats

:tropical_fish: Beats - Lightweight shippers for Elasticsearch & Logstash

https://www.elastic.co/products/beats

Other

103 stars 4.92k forks source link

[filebeat][gcs] - Simplified state checkpoint calculation #40937

Closed ShourieG closed 1 month ago

ShourieG commented 1 month ago

Type of change

Enhancement

Proposed commit message

WHAT: Simplified state checkpoint calculation
WHY: The existing state checkpoint calculation logic was convoluted and depended on unreliable flag logic, then it has been simplified so that if errors occur they are become simpler to debug.

Checklist

[x] My code follows the style guidelines of this project
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have made corresponding change to the default configuration files
[ ] I have added tests that prove my fix is effective or that my feature works
[x] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

How to test this PR locally

Related issues

Closes #40878
Relates #40936

Use cases

Screenshots

Logs

mergify[bot] commented 1 month ago

This pull request does not have a backport label. If this is a bug or security fix, could you label this PR @ShourieG? 🙏. For such, you'll need to label your PR with:

The upcoming major version of the Elastic Stack
The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed branches, such as:

backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

mergify[bot] commented 1 month ago

backport-8.x has been added to help with the transition to the new branch 8.x. If you don't need it please use backport-skip label and remove the backport-8.x label.

elasticmachine commented 1 month ago

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

ShourieG commented 1 month ago

@efd6, updated with similar changes as the abs input.

mergify[bot] commented 1 month ago

This pull request is now in conflicts. Could you fix it? 🙏 To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b gcs/simplify_state upstream/gcs/simplify_state
git merge upstream/main
git push upstream gcs/simplify_state