elastic / beats

:tropical_fish: Beats - Lightweight shippers for Elasticsearch & Logstash
https://www.elastic.co/products/beats
Other
109 stars 4.93k forks source link

[8.x](backport #41622) [meraki] Log `getDevicePerformanceScores` errors #41659

Closed mergify[bot] closed 1 week ago

mergify[bot] commented 1 week ago

Overview

Currently, getDevicePerformanceScores stops the entire metric collection if it encounters an error for a single device that does not support this feature, impacting data collection for other devices. The function should log the errors and skip models with issues, ensuring that metric collection continues smoothly.

Checklist

Disruptive User Impact

Author's Checklist

How to test this PR locally

Related issues

Use cases

Screenshots

Logs


This is an automatic backport of pull request #41622 done by Mergify.

elasticmachine commented 1 week ago

Pinging @elastic/integrations (Team:Integrations)

pierrehilbert commented 1 week ago

@gpop63 Looks like you will have to remove the extra entry in the changelog otherwise it looks good to be merged.

pierrehilbert commented 1 week ago

Thanks for the quick action. This one being a backport, you should be able to approve it by yourself and be able to move forward.