Creation of StackConfigPolicy - Cluster Settings

[knechtionscoding]

Bug Report

What did you do?

Tried to configure cluster settings via a StackConfigPolicy:

apiVersion: stackconfigpolicy.k8s.elastic.co/v1alpha1
kind: StackConfigPolicy
metadata:
  name: test
spec:
  elasticsearch:
    clusterSettings:
      persistent:
        cluster:
          routing:
            rebalance:
              enable: all
            allocation:
              enable: all
        xpack:
          monitoring:
            collection:
              enabled: 'true'

you'll get:

        message: >-
          Error processing cluster_settings state change:
          java.lang.IllegalArgumentException: persistent setting
          [persistent.xpack.monitoring.collection.enabled], not recognized

And if you try any transient settings:

apiVersion: stackconfigpolicy.k8s.elastic.co/v1alpha1
kind: StackConfigPolicy
metadata:
  name: test
spec:
  elasticsearch:
    clusterSettings:
      transient:
        cluster:
          routing:
            allocation:
              node_concurrent_recoveries: '8'

you'll see:

        message: >-
          Error processing cluster_settings state change:
          java.lang.IllegalArgumentException: persistent setting
          [transient.cluster.routing.allocation.node_concurrent_recoveries], not
          recognized

Possibly related to #6495 and #6694

What did you expect to see?

Cluster settings configured

What did you see instead? Under which circumstances?

Errors:

        message: >-
          Error processing cluster_settings state change:
          java.lang.IllegalArgumentException: persistent setting
          [persistent.xpack.monitoring.collection.enabled], not recognized

and

        message: >-
          Error processing cluster_settings state change:
          java.lang.IllegalArgumentException: persistent setting
          [transient.cluster.routing.allocation.node_concurrent_recoveries], not
          recognized

Environment

• ECK version: 2.7.0

• Kubernetes information:

  insert any information about your Kubernetes environment that could help us:

  • Cloud: GKE

  for each of them please give us the version you are using

  $ kubectl version
  Client Version: version.Info{Major:"1", Minor:"26", GitVersion:"v1.26.3", GitCommit:"9e644106593f3f4aa98f8a84b23db5fa378900bd", GitTreeState:"clean", BuildDate:"2023-03-15T13:33:11Z", GoVersion:"go1.19.7", Compiler:"gc", Platform:"darwin/amd64"}
  Kustomize Version: v4.5.7
  Server Version: version.Info{Major:"1", Minor:"24", GitVersion:"v1.24.10-gke.2300", GitCommit:"1d7ae0799b40b0cd95502e3a5e698db62572e341", GitTreeState:"clean", BuildDate:"2023-02-22T09:28:49Z", GoVersion:"go1.19.6 X:boringcrypto", Compiler:"gc", Platform:"linux/amd64"}

• Resource definition:

  if relevant insert the resource definition

• Logs:

  insert operator logs or any relevant message to the issue here

[thbkrkr]

When you configure cluster settings through a StackConfigPolicy, you are declaring persistent settings, so persistent or transient fields don't make sense in this context.

apiVersion: stackconfigpolicy.k8s.elastic.co/v1alpha1
kind: StackConfigPolicy
metadata:
  name: test
spec:
  elasticsearch:
    clusterSettings:
      cluster.routing.rebalance.enable: all
      cluster.routing.allocation.enable: all
      cluster.routing.allocation.node_concurrent_recoveries: '8'
      xpack.monitoring.collection.enabled: 'true'

Note that you can choose between the indentation notation (in your example) or the dot notation (in the example above).

I will try to improve the documentation.

[knechtionscoding]

Ah, makes sense. Confirmed that works