Add more topology changes e2e tests with multiple ES versions

elastic / cloud-on-k8s

Elastic Cloud on Kubernetes

Other

2.59k stars 704 forks source link

Add more topology changes e2e tests with multiple ES versions #679

Open sebgl opened 5 years ago

sebgl commented 5 years ago

To avoid issues such as #678, we should have more topology changes in our mutation e2e tests. They should cover various Elasticsearch major versions (for now: 6.X and 7.X).

charith-elastic commented 5 years ago

If I am not mistaken, the case described in #678 is already covered: https://github.com/elastic/cloud-on-k8s/blob/e6d2a411418c9c2675c3f43d568e7431af1fffb3/operators/test/e2e/es/mutation_test.go#L48

Are there other scenarios that need tests?

sebgl commented 5 years ago

Things that come to my mind (may not be worth a test for each of them!):

mutate ES version and ES settings and resources requests at the same time
rename a NodeSpec (once StatefulSets impl. is merged)
upgrade (config or resources change) the single master of a cluster
mutate hot-warm clusters

pebrc commented 3 years ago

[ ] mutate ES version and ES settings and resources requests at the same time
[x] rename a NodeSpec (once StatefulSets impl. is merged) Test
[ ] upgrade (config or resources change) the single master of a cluster (we have few single master tests but none that updates that single master afaik)
[ ] mutate hot-warm clusters (we don't have any ILM related tests, and I am not sure if we should start writing them given that the node shutdown API is coming and the operator does not manage ILM at the moment.)