Keep all Elasticsearch topologies when building update request.

gigerdo commented 1 year ago

The response from the API does already contain all topologies, but they were removed when building the update request. Now we simply keep all elements as the API returns them.

This is mainly needed when autoscaling is enabled. In that case the update request must contain all existing topology elements to validate correctly.

Description

Related Issues

Fixes an ecctl issue: https://github.com/elastic/ecctl/issues/596

Motivation and Context

How Has This Been Tested?

Types of Changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Refactoring (improves code quality but has no user-facing effect)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation

Readiness Checklist

[x] My code follows the code style of this project
[ ] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[x] All new and existing tests passed

gigerdo commented 1 year ago

Had to force push my commits to sign them.

henrikno commented 1 year ago

This also fixes https://github.com/elastic/cloud-sdk-go/issues/366. Thanks!

elastic / cloud-sdk-go

Keep all Elasticsearch topologies when building update request. #416