Closed orouz closed 1 month ago
This pull request does not have a backport label. Could you fix it @orouz? 🙏 To fixup this pull request, you need to add the backport labels for the needed branches, such as:
backport-v./d./d./d
is the label to automatically backport to the 8./d
branch. /d
is the digit
NOTE: backport-skip
has been added to this pull request.Result | Count |
---|---|
🟥 Failed | 0 |
🟩 Passed | 359 |
⬜ Skipped | 33 |
Summary of your changes
this PR:
InitializeAWSConfig
function ends up returning anaws.Config
withRetryer
asnil
, so without adding it we're not opting-in to the default retry mechanism429
as an additional, retryable HTTP status code.Implementation notes
the first commit of this PR can be considered an alternative, standalone implementation of doing the same thing the 2nd commit does. the difference between the two, is that the 2nd commit removes the
ConfigProvider
in favor of a plain function to encapsulate AWS config initialization (via libbeat) + adding a retryer. to do so, some code was removed and now all AWS config initializations call the same function, and the only consumer of the now-deleted AWS config provider (EKS) sets the region manually (which is what the provider did)all in all - the 2nd commit's diff is bigger, but i think it does some nice cleanup too. although, we could go with the 1st if preferable.
Related Issues
Checklist