Closed romulets closed 2 months ago
This pull request does not have a backport label. Could you fix it @romulets? 🙏 To fixup this pull request, you need to add the backport labels for the needed branches, such as:
backport-v./d./d./d
is the label to automatically backport to the 8./d
branch. /d
is the digit
NOTE: backport-skip
has been added to this pull request.Result | Count |
---|---|
🟥 Failed | 0 |
🟩 Passed | 331 |
⬜ Skipped | 34 |
Summary of your changes
related.entities
field directly oninventory.go
. I considered having another structure calledRelated
that would the fieldentities
. I didn't do it because I don't believe we should duplicate this data,Asset.Id
is the source of truth, having a duplicated slice could lead to inconsistency, and even if we have a reference, seems like overcomplicating. I considered thisrelated.entities
as an ECS related concern. Theasset.go
map the domain used inside cloudbeat, andinventory.go
is dealing with elasticsearch integration, ecs concern and so on. Of course we map the Asset to match ECS, we shouldn't have data translation layers here. But on this subject I decided to implement on inventory. I'm open to hear different opinions.Screenshots
Related Issues