Fix the extraction of the dependencies in the gemspec

tarekziade commented 1 year ago

Fetching git@github.com:elastic/connectors-ruby

[!] There was an error while loading `connectors_service.gemspec`: Illformed requirement [#<Gem::Requirement:0x5da1a97f @requirements=[["~>", #<Gem::Version "1.0">], [">=", #<Gem::Version "1.0.1">]], @_sorted_requirements=[[">=", #<Gem::Version "1.0.1">], ["~>", #<Gem::Version "1.0">]], @_tilde_requirements=[["~>", #<Gem::Version "1.0">]]>]. Bundler cannot continue.

 #  from /Users/tarekziade/Dev/ent-search/vendor/bundle/jruby/2.6.0/bundler/gems/connectors-ruby-7331cbf40964/connectors_service.gemspec:22
 #  -------------------------------------------
 #      else
 >        s.add_dependency dep.name, dep.requirement
 #      end
 #  -------------------------------------------

ERROR: Bundle command failed!

Checklists

Pre-Review Checklist

[x] Covered the changes with automated tests
[x] Tested the changes locally

Changes Requiring Extra Attention

[ ] Security-related changes (encryption, TLS, SSRF, etc)
[ ] New external service dependencies added.

Related Pull Requests

Release Note

For Elastic Internal Use Only

[ ] Considered corresponding documentation changes to contribute separately
[ ] New configuration settings added in this PR follow the official guidelines
[ ] Built gems (both connectors_utility and connectors_service) and included into Enterprise Search and tested that Enterprise Search works well with new gem versions. Instruction can be found here

artem-shelkovnikov commented 1 year ago

@tarekziade while PR content looks good, can you update the PR description, remove not needed checklists and test locally before merging?

tarekziade commented 1 year ago

@tarekziade while PR content looks good, can you update the PR description, remove not needed checklists and test locally before merging?

I ran:

make test
make build_service_gem
make build_utility_gem

github-actions[bot] commented 1 year ago

💚 Backport PR(s) successfully created

Status	Branch	Result
✅	8.6	https://github.com/elastic/connectors-ruby/pull/466

This backport PR will be merged automatically after passing CI.

github-actions[bot] commented 1 year ago

💔 Failed to create backport PR(s)

The backport operation could not be completed due to the following error: There are no branches to backport to. Aborting.

The backport PRs will be merged automatically after passing CI.

To backport manually run: backport --pr 445 --autoMerge --autoMergeMethod squash

elastic / connectors-ruby