search

elastic / connectors-ruby

Official Connector Clients for Elastic Elasticsearch, Enterprise Search, App Search and Workplace Search
https://www.elastic.co/guide/en/enterprise-search/master/index.html
Other
9 stars 17 forks source link

Update CONNECTOR_PROTOCOL.md #508

Closed artem-shelkovnikov closed 1 year ago

artem-shelkovnikov commented 1 year ago

Found when working on connectors-python repository.

There's expectation that connector id is stored within Jobs index inside connector.id, but protocol says it should be connector.connector_id - this seems incorrect.

Plus' moved id on top of connector object - good to have ids as first fields of objects.

github-actions[bot] commented 1 year ago

💔 Failed to create backport PR(s)

The backport operation could not be completed due to the following error: There are no branches to backport to. Aborting.

The backport PRs will be merged automatically after passing CI.

To backport manually run: backport --pr 508 --autoMerge --autoMergeMethod squash