elastic / connectors-ruby

Official Connector Clients for Elastic Elasticsearch, Enterprise Search, App Search and Workplace Search
https://www.elastic.co/guide/en/enterprise-search/master/index.html
Other
9 stars 17 forks source link

[Filtering] Respect filtering feature flags #511

Closed timgrein closed 1 year ago

timgrein commented 1 year ago

Closes https://github.com/elastic/enterprise-search-team/issues/3658

This PR introduces the capability to the framework to not schedule filtering validation tasks if all filtering features are disabled. It also skips this validation and filtering with basic rules in a sync job if all filtering features are disabled. If filtering with basic rules is disabled but filtering with the advanced rules is enabled it stills executes the validation in the sync job without applying basic rule filtering.

Checklists

Pre-Review Checklist

github-actions[bot] commented 1 year ago

💔 Failed to create backport PR(s)

The backport operation could not be completed due to the following error: There are no branches to backport to. Aborting.

The backport PRs will be merged automatically after passing CI.

To backport manually run: backport --pr 511 --autoMerge --autoMergeMethod squash