Implement nested features

artem-shelkovnikov commented 1 year ago

Closes https://github.com/elastic/enterprise-search-team/issues/3653

This PR implements new connector features structure:

{
"features": {
  "sync_rules": {
    "basic" : { "enabled" : true },
    "advanced": {"enabled":true }
  }
}

While this structure is also implemented and used, old structure is still maintained and used for backwards compatibility.

[x] Covered the changes with automated tests
[x] Tested the changes locally
[x] Added a label for each target release version (example: v7.13.2, v7.14.0, v8.0.0)

[ ] Built gems (both connectors_utility and connectors_service) and included into Enterprise Search and tested that Enterprise Search works well with new gem versions. Instruction can be found here

seanstory commented 1 year ago

Also needs to update the CONNECTOR_PROTOCOL.md file with this new structure

artem-shelkovnikov commented 1 year ago

Good point @seanstory, updated!

I'm not sure about naming though - I've called nested keys "feature"."subfeature", but is this naming actually correct? cc @timgrein @sphilipse

seanstory commented 1 year ago

I think that works just fine. We can update it later if there's confusion.

github-actions[bot] commented 1 year ago

The backport operation could not be completed due to the following error: There are no branches to backport to. Aborting.

The backport PRs will be merged automatically after passing CI.

To backport manually run: backport --pr 530 --autoMerge --autoMergeMethod squash