search

elastic / connectors

Source code for all Elastic connectors, developed by the Search team at Elastic, and home of our Python connector development framework
https://www.elastic.co/guide/en/enterprise-search/master/index.html
Other
59 stars 118 forks source link

Impossible to terminate running connector service from source #2568

Open jedrazb opened 1 month ago

jedrazb commented 1 month ago

Bug Description

To Reproduce

Steps to reproduce the behavior:

  1. Start make run
  2. Do some syncs with connector configured
  3. Try to terminate, sometimes you run into 
    ^C[12:08:30][INFO] Caught SIGINT. Graceful shutdown.
^C[12:18:37][INFO] Caught SIGINT. Graceful shutdown.

And the service doesn't terminate gracefully.

Expected behavior

We should support graceful termination on SIGINT

seanstory commented 1 month ago

@jedrazb what command did you use to start the container? I would expect --tty -i would ensure this works, and I haven't had any issue before.

jedrazb commented 3 weeks ago

what command did you use to start the container? I would expect --tty -i would ensure this works, and I haven't had any issue before.

It was actually make run when running from source. I clarified with the engineer affected, it was from source (updated the issue).