elastic / connectors

Source code for all Elastic connectors, developed by the Search team at Elastic, and home of our Python connector development framework
https://www.elastic.co/guide/en/enterprise-search/master/index.html
Other
71 stars 126 forks source link

Cannot connect to JIRA Cloud due to ‘:’ in account id #2614

Closed salyia closed 2 months ago

salyia commented 3 months ago

Bug Description

When using a Jira Cloud service account id that contains a ':' (colon), Jira connection fails with the following error:

[FMWK][08:57:58][ERROR] [Connector id: xxxxx, index name: mycompany-jira, Sync job id: xxxxx] A ":" is not allowed in login (RFC 1945#section-11.1)

To Reproduce

Steps to reproduce the behavior:

  1. Create a Jira connector at https://KIBANA_URL/app/enterprise_search/content/connectors
  2. Specify a Jira Cloud service account id that contains a ':' , e.g. 123456:SOMEUUID4 (Don't have to be a valid Jira Cloud service account id)
  3. Save the configuration then click Sync (choose either Full or Incremental sync)

Expected behavior

Connector connects to Jira and syncing starts.

Screenshots

image

Environment

Linux

Additional context

See screenshot

salyia commented 3 months ago

It seems the admin email had to be provided for service id...

artem-shelkovnikov commented 3 months ago

@elastic/ingestion-team is it worth to update the field name/tooltip to avoid confusion? Maybe also add backend validation for the field?

cc @danajuratoni

seanstory commented 3 months ago

I like the idea of just modifying the tooltip. Also adding some positive examples to the documentation for configuration would be good. Right now the descriptions just reword the field names, which isn't super helpful. https://www.elastic.co/guide/en/enterprise-search/current/connectors-jira.html#connectors-jira-configuration

moxarth-elastic commented 2 months ago

Closing this issue as the PR is merged. Please feel free to re-open in case of any concern.