elastic / connectors

Source code for all Elastic connectors, developed by the Search team at Elastic, and home of our Python connector development framework
https://www.elastic.co/guide/en/enterprise-search/master/index.html
Other
58 stars 116 forks source link

[Jira] Add tooltip for service account id #2640

Closed moxarth-elastic closed 1 day ago

moxarth-elastic commented 2 weeks ago

Part of https://github.com/elastic/connectors/issues/2614

Added a tooltip to avoid the confusion for the Jira Cloud service account id configuration.

If this is an ad-hoc/trivial change and does not have a corresponding issue, please describe your changes in enough details, so that reviewers and other team members can understand the reasoning behind the pull request.-->

Checklists

Pre-Review Checklist

moxarth-elastic commented 2 weeks ago

@leemthompo we need to update the following changes in the Jira documentation:

For Native connector (https://www.elastic.co/guide/en/enterprise-search/current/connectors-jira.html#connectors-jira-configuration):

Update: Jira Cloud service account id - The email address to authenticate with Jira cloud. Example: alex.wilber@gmail.com

For Connector client (self-managed) (https://www.elastic.co/guide/en/enterprise-search/current/connectors-jira.html#connectors-jira-connector-client-reference): Update: account_email - The email address to authenticate with Jira cloud. Example: alex.wilber@gmail.com

artem-shelkovnikov commented 1 week ago

Re: failing pipeline - it's something happening on our side, we're taking care of it

artem-shelkovnikov commented 1 week ago

@moxarth-elastic the change looks good, can we also have a change for Kibana repository to do the same thing?

moxarth-elastic commented 5 days ago

@moxarth-elastic the change looks good, can we also have a change for Kibana repository to do the same thing?

Yes, i'll make the changes for Kibana.

leemthompo commented 4 days ago

@leemthompo we need to update the following changes in the Jira documentation:

Is this targeting just main or will it be back ported?

artem-shelkovnikov commented 4 days ago

@leemthompo It's only for main, too minor of a bug to backport far :)

moxarth-elastic commented 4 days ago

@artem-shelkovnikov i've raised a Kibana PR for the same, can you please add the labels to make the CI pass?