[Confluence] Fix data loss for Data Center during Advance-Sync

parth-elastic commented 4 days ago

Closes https://github.com/elastic/connectors-py/issues/2631

Changed LIMIT value to 50 as the original LIMIT value of 100 was causing the loop to break prematurely in the paginated_api_call_for_datacenter_syncrule method as the results limit is updated to 50.

Checklists

Pre-Review Checklist

[x] this PR does NOT contain credentials of any kind, such as API keys or username/passwords (double check config.yml.example)
[x] this PR has a meaningful title
[x] this PR links to all relevant github issues that it fixes or partially addresses
[x] if there is no GH issue, please create it. Each PR should have a link to an issue
[x] this PR has a thorough description
[x] Covered the changes with automated tests
[x] Tested the changes locally
[x] Added a label for each target release version (example: v7.13.2, v7.14.0, v8.0.0)
[ ] Considered corresponding documentation changes
[ ] Contributed any configuration settings changes to the configuration reference
[ ] if you added or changed Rich Configurable Fields for a Native Connector, you made a corresponding PR in Kibana

Changes Requiring Extra Attention

[ ] Security-related changes (encryption, TLS, SSRF, etc)
[ ] New external service dependencies added.

Related Pull Requests

Release Note

Fixing data loss in Confluence connector when advanced sync rule is enabled.

artem-shelkovnikov commented 4 days ago

Great catch!

github-actions[bot] commented 3 days ago

💔 Failed to create backport PR(s)

Status	Branch	Result
❌	8.14	Commit could not be cherrypicked due to conflicts

To backport manually run: backport --pr 2651 --autoMerge --autoMergeMethod squash

seanstory commented 3 days ago

@praveen-elastic can you manually resolve the commits and backport? ☝️

elastic / connectors