elastic / connectors

Source code for all Elastic connectors, developed by the Search team at Elastic, and home of our Python connector development framework
https://www.elastic.co/guide/en/enterprise-search/master/index.html
Other
73 stars 126 forks source link

Postgres advanced sync rules missing in Native Connectors #2686

Closed seanstory closed 2 months ago

seanstory commented 3 months ago

Bug Description

https://github.com/elastic/kibana/blob/dd9d6434cae8b7beb3b730cd42898b8f63dbee91/packages/kbn-search-connectors/types/native_connectors.ts#L3867 specifies that Advanced Sync Rules for the Postgres Native Connector are disabled. But these should have been enabled as part of https://github.com/elastic/connectors/pull/1691 for 8.11

To Reproduce

Expected behavior

Advanced Sync Rules should be available

Screenshots

image

Environment

8.11-8.14

Workaround

Get the connector's ID. You can find this by doing a GET .elastic-connectors/_search and looking for the right connector. Then execute the below Elasticsearch request, replacing <connector_id> with your connector's ID.

POST .elastic-connectors/_update/<connector_id>
{
  "doc": {
    "features": {
      "sync_rules": {
        "advanced": {
          "enabled": true
         }
      }
    }
  }
}
praveen-elastic commented 3 months ago

But these should have been enabled as part of https://github.com/elastic/connectors/pull/1691 for 8.11

@seanstory back in September, 2023 when this PR for Postgres https://github.com/elastic/connectors/pull/1691 got merged there was no checklist that stated raising a PR on Kibana for native connector changes. The Checklist item might have been introduced later. Before that, the changes to Kibana files was being taken care by Elastic.

However, we're happy to fix this.

praveen-elastic commented 2 months ago

Upon further investigation it was found that some more connectors were having similar issue. This was determined by checking which connectors has support for Advanced sync rules using: https://github.com/search?q=repo%3Aelastic%2Fconnectors+%22advanced_rules_enabled+%3D+True%22&type=code

cc @navarone-feekery