add docker images to dra

seanstory commented 2 months ago

Part of https://github.com/elastic/search-team/issues/8047

This will add docker images to our DRA src dir. When combined with a change to the infra definition of our dra gradle file (https://github.com/elastic/infra/pull/41437), it will allow us to get rid of our own release.yml pipeline, and instead rely on the Unified Release and the Agent Release for all our needs going forward.

Checklists

Pre-Review Checklist

[x] this PR does NOT contain credentials of any kind, such as API keys or username/passwords (double check config.yml.example)
[x] this PR has a meaningful title
[x] this PR links to all relevant github issues that it fixes or partially addresses
[x] this PR has a thorough description
[x] Tested the changes locally
[x] Added a label for each target release version (example: v7.13.2, v7.14.0, v8.0.0)

Related Pull Requests

Infra PR: https://github.com/elastic/infra/pull/41437

seanstory commented 2 months ago

Ready for re-review!

seanstory commented 2 months ago

Do we need to verify that the Docker build steps work as expected, before merging this?

I did that before I opened this for review. I used to have if: "(build.branch == \"main\" || build.branch == \"seanstory/add-docker-images-to-DRA\") :) That's how I got the artifacts linked in the description.

build.pull_request.labels includes \"ci:packaging\")", as we do for ent-search. In that case, we should split the :truck: DRA group in two (one for packaging, one for publishing), again similarly to what we have for ent-search.

I'm not opposed, but I didn't want to add too much scope and I think ent-search has magic to decide when to add that label. And I don't think we typically want maintenance branches to build these? But we can add this later if we want/need it.