add back release pipeline

seanstory commented 2 months ago

Closes https://github.com/elastic/search-team/issues/8226

This PR does a few things.

Adds back the scripts that used to exist for triggering a manual release
Introduces a MANUAL_RELEASE env var (through the pipeline) that gates some special versioning logic
That logic (in publish-common.sh) will re-compute the VERSION by going to the most recent patch version, and adding a +build<timestamp> suffix (this matches the pattern that Agent is establishing)
The pipeline adds a setup and a cleanup group, which actually commit the VERSION file change and create a git tag on that commit. This ensures that the docker tag, git tag, and bin/elastic-ingest --version all are in agreement.
every part of this pipeline is gated, and can only be run off of X.Y branches (not main, not other dev branches)

Checklists

Pre-Review Checklist

[x] this PR does NOT contain credentials of any kind, such as API keys or username/passwords (double check config.yml.example)
[x] this PR has a meaningful title
[x] this PR links to all relevant github issues that it fixes or partially addresses
[x] this PR has a thorough description
[x] Covered the changes with automated tests
[x] Tested the changes locally
[x] Added a label for each target release version (example: v7.13.2, v7.14.0, v8.0.0)
[x] Considered corresponding documentation changes

Changes Requiring Extra Attention

[ ] added automated committing and tagging to a buildkite pipeline

Related Pull Requests

https://github.com/elastic/ci/pull/3327 gave the elastic CI bot push access

seanstory commented 2 months ago

Tada got it working! https://buildkite.com/elastic/connectors-docker-build-publish/builds/48

seanstory commented 2 months ago

Adding Productivity team as optional reviewers, since this is so much buildkite and bash, and y'all are the subject matter experts here.

seanstory commented 2 months ago

This is ready for review

seanstory commented 2 months ago

ie, if we just have one commit that adds back the original files that were deleted (as-is, with no changes)

That's this commit: 66c6d138bf703f1d30fbdd21d64fee2d11cf82cc

and then add a commit with just the required changes to those files. [...] Reviewing this PR would be tremendously easier for rubber-stampers

I can squash all the other commits, but I'll be honest, I'm not looking for a rubber stamp, I am looking for a real review, especially because this PR adds automated committing and tagging. I feel like I've done pretty thorough manual testing, but a critical set of eyes never hurts.

github-actions[bot] commented 2 months ago

💚 Backport PR(s) successfully created

Status	Branch	Result
✅	8.x	https://github.com/elastic/connectors/pull/2834

This backport PR will be merged automatically after passing CI.

elastic / connectors