search

elastic / crawler

Other
125 stars 10 forks source link

Fix usage of in-built `File` lib #139

Closed navarone-feekery closed 2 months ago

navarone-feekery commented 2 months ago

Closes https://github.com/elastic/crawler/issues/138

The output sink Crawler::OutputSink::File was calling the in-built lib File, but was confusing that lib for itself. This forces the usage of ::File so that ruby knows to use the internal lib instead.

(I'm not sure how this worked before, but possibly caused by upgrading the jruby version?)

Release note

🐛 Fixed a bug that caused the file output sink to not work

navarone-feekery commented 2 months ago

💚 All backports created successfully

Status Branch Result
✅ 0.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation