elastic / crawler

Other
125 stars 10 forks source link

Bump nokogiri, tika, remove explicit bouncycastle #165

Closed seanstory closed 6 days ago

seanstory commented 1 week ago

part of https://github.com/elastic/search-team/issues/7528

This bumps two outdated deps, and removes a known dependency misalginment between tika an an explicit bouncy-castle dep.

Checklists

Pre-Review Checklist

seanstory commented 6 days ago

I hope not. 😰 This just makes the same change we made to ent-search after all the investigation and stress. Because this removes the explicit version constraint on bouncycastle, this lets the direct deps pick the right version for the transitive, so there shouldn't be any issue here.

It is suprirsing that without this change we didn't see any bugs. My guess is it's because we don't even need Tika in this project at all anymore. We need to do an audit and just remove the unused deps, so that we don't have to bother keeping them updated.