search

elastic / crd-ref-docs

Generates Kubernetes CRD API reference documentation
Apache License 2.0
103 stars 53 forks source link

Support multi arch release #78

Closed airycanon closed 3 months ago

airycanon commented 6 months ago

fix #57 #71

Changes:

airycanon commented 6 months ago

@thbkrkr @tenstad PTAL

thbkrkr commented 5 months ago

Thanks for taking care of this. I would prefer that we rely on goreleaser/goreleaser-action and also include the version in the binary like here: https://github.com/elastic/eck-diagnostics/blob/main/.github/workflows/release.yml. Could you follow the same approach?

airycanon commented 5 months ago

Thanks for taking care of this. I would prefer that we rely on goreleaser/goreleaser-action and also include the version in the binary like here: https://github.com/elastic/eck-diagnostics/blob/main/.github/workflows/release.yml. Could you follow the same approach?

Thanks for the suggestion. I have already implemented it accordingly, here is a release sample: https://github.com/airycanon/crd-ref-docs/releases/tag/v0.0.1

the version output: 

$ ./crd-ref-docs --version
Version: v0.0.1, Commit: aabf3eb, BuildDate: 2024-05-16T03:28:28Z
thbkrkr commented 3 months ago

Thank you very much for this contribution.