search

elastic / data-extraction-service

Other
12 stars 0 forks source link

Add license information headers to code files #27

Closed navarone-feekery closed 5 months ago

navarone-feekery commented 6 months ago

Add missing license information to the top of code files.

seanstory commented 6 months ago

Also, do we need to cover runner.sh and everything in scripts/?

navarone-feekery commented 6 months ago

What would you think about adding a test to check that the headers are present on all .lua and .py and .conf files in the repo?

That seems reasonable, I'll add that 👍🏻

Also, do we need to cover runner.sh and everything in scripts/?

We don't in the connectors repo. Do you know if there's any official guidelines about what types of files should have this header?

navarone-feekery commented 6 months ago

I found in the Elastic open source guidelines that we need headers of all "source code files". I don't know how scripts fall into that but we might as well add them just to cover all bases.

seanstory commented 6 months ago

Do you know if there's any official guidelines about what types of files should have this header? I don't know how scripts fall into that but we might as well add them just to cover all bases.

Yeah same. It's one of those things that the Open Source team will look at and give us a 👍 or a 👎. So I figure more headers can't hurt. 🤷