[FR] Detection Rule PR Guidelines and Issue Forms - Githubissues

elastic / detection-rules

https://www.elastic.co/guide/en/security/current/detection-engine-overview.html

Other

1.85k stars 462 forks source link

[FR] Detection Rule PR Guidelines and Issue Forms #3850

Open Mikaayenson opened 4 days ago

Mikaayenson commented 4 days ago

Issues

Related to https://github.com/elastic/ia-trade-team/issues/372 Resolves https://github.com/elastic/detection-rules/issues/1888

Summary

Adds initial guidelines for different PR types
Converts issue templates to issue forms
Adds a GitHub action workflow to populate guidelines based on label. Updates the guideline comment instead of adding a new comment based on label.
Removes unused release templates

Additional Info

GitHub doesn't allow multiple PR request templates similar to the way templates are implemented for GitHub issues, so we leverage GitHub action workflows to generate a "comment" with the appropriate guidelines based on the GitHub label applied (bug, enhancement, schema, Rule: New, Rule: Deprecation, or Rule: Tuning). This is instead of relying on PR authors to tweak URL queries to populate the PR. See more context.