elastic / detection-rules

https://www.elastic.co/guide/en/security/current/detection-engine-overview.html
Other
1.92k stars 492 forks source link

[Bug] Normalize Hunting Index Link Generation #3872

Closed terrancedejesus closed 3 months ago

terrancedejesus commented 3 months ago

Related Issues

Summary

This pull request fixes a bug in the hunting folder where reference links in the index.md file were generating according to the platform generate_markdown.py was executed on.

courtesy of @Aegrah image (3)

Additional Information

Testing

  1. Checkout branch
  2. Run python hunting/generate_markdown.py on a Windows platform
Aegrah commented 3 months ago

Thank you @terrancedejesus, will let the actual developers do the review, however.

terrancedejesus commented 3 months ago

Thank you @terrancedejesus, will let the actual developers do the review, however.

@Aegrah Since others may not have a Windows host available. Can you please use this branch to make sure the paths are not changed as you saw before. I have tested on my Windows host, but want to confirm with another.

terrancedejesus commented 3 months ago

@Aegrah thanks for spotting this! I removed the accented characters, which only seemed to be present where the [a-zA-Z0-9] regex pattern in 5 separate files, but throughout multiple queries in those files. It was [a-zA-Z0-9ñ originally and then when loaded and MD docs generated again, changed to the accented A and +. I did not identify when those were added, but they have been fixed. Can you confirm that everything is good on your end now?

Aegrah commented 3 months ago

@terrancedejesus, ran the markdown generator and now everything looks g2g. Nice.