eric-forte-elastic commented 2 months ago

Pull Request

Issue link(s): https://github.com/elastic/ia-trade-team/issues/345

Summary - What I changed

Minor potential bug in Validates Data function where it is supposed to only fire against Elastic authored rules but currently fires against all rules regardless of author.

How To Test

Try exporting a rule from Kibana with version and revision where the author is not Elastic. This should pass schema validation.

Example TOML Rule

``` [metadata] creation_date = "2024/07/24" maturity = "production" updated_date = "2024/07/24" [rule] actions = [] author = ["sigma", "Some User"] data_view_id = "any-hosts" description = "Zdarzenie wykrycia dodania do wyjątków ścieżki, która może być potencjalnie nadużyta." enabled = true exceptions_list = [] false_positives = ["Testy penetracyjne"] from = "now-540s" interval = "5m" language = "kuery" license = "" max_signals = 100 name = "H-DEFENSEEVASION-266 - Windows Defender Exclusions Added" note = """Sprawdź nazwę stacji - host.name Sprawdź jaki wyjątek został dodany - winlog.event_data.New Value Sprawdź czy może być to związane z testami penetracyjnymi prowadzonymi w ramach SI. """ references = [ "https://github.com/SigmaHQ/sigma/blob/master/rules/windows/builtin/windefend/win_defender_config_change_exclusion_added.yml", ] related_integrations = [] required_fields = [] revision = 0 risk_score = 47 risk_score_mapping = [] rule_id = "c7249101-0ea3-4ded-8e65-0d46295eac54" setup = "Wymaga logów z Microsoft-Windows-Windows Defender\n" severity = "medium" severity_mapping = [] tags = ["Windows", "Q2-24", "Windows Defender", "sigma"] threat = [] to = "now" type = "query" version = 1 query = ''' event.code : 5007 and "winlog.event_data.New Value" : (*\\Users\\* or *\\AppData\\Local\\Temp\\* or *\\Desktop\\* or *\\PerfLogs\\* or *\\Windows\\Temp\\*) ''' [[rule.filters]] [rule.filters."$state"] store = "appState" [rule.filters.meta] disabled = false field = "event.provider" index = "any-hosts" key = "event.provider" negate = false type = "phrase" [rule.filters.meta.params] query = "Microsoft-Windows-Windows Defender" [rule.filters.query.match_phrase] "event.provider" = "Microsoft-Windows-Windows Defender" [rule.investigation_fields] field_names = ["event.code", "event.provider", "winlog.event_data.New Value", "host.name", "winlog.user.name"] [rule.meta] from = "4m" kibana_siem_app_url = "https://mordor.szperacz.lynx.net/s/soc/app/security" ```

Checklist

[x] Added a label for the type of pr: bug, enhancement, schema, Rule: New, Rule: Deprecation, Rule: Tuning, Hunt: New, or Hunt: Tuning so guidelines can be generated
[x] Added the meta:rapid-merge label if planning to merge within 24 hours
[ ] Secret and sensitive material has been managed correctly
[ ] Automated testing was updated or added to match the most common scenarios
[ ] Documentation and comments were added for features that require explanation

Contributor checklist

Have you signed the contributor license agreement?
Have you followed the contributor guidelines?

protectionsmachine commented 2 months ago

Bug - Guidelines

These guidelines serve as a reminder set of considerations when addressing a bug in the code.

Documentation and Context

[ ] Provide detailed documentation (description, screenshots, reproducing the bug, etc.) of the bug if not already documented in an issue.
[ ] Include additional context or details about the problem.
[ ] Ensure the fix includes necessary updates to the release documentation and versioning.

Code Standards and Practices

[ ] Code follows established design patterns within the repo and avoids duplication.
[ ] Code changes do not introduce new warnings or errors.
[ ] Variables and functions are well-named and descriptive.
[ ] Any unnecessary / commented-out code is removed.
[ ] Ensure that the code is modular and reusable where applicable.
[ ] Check for proper exception handling and messaging.

Testing

[ ] New unit tests have been added to cover the bug fix or edge cases.
[ ] Existing unit tests have been updated to reflect the changes.
[ ] Provide evidence of testing and detecting the bug fix (e.g., test logs, screenshots).
[ ] Validate that any rules affected by the bug are correctly updated.
[ ] Ensure that performance is not negatively impacted by the changes.
[ ] Verify that any release artifacts are properly generated and tested.

Additional Checks

[ ] Ensure that the bug fix does not break existing functionality.
[ ] Review the bug fix with a peer or team member for additional insights.
[ ] Verify that the bug fix works across all relevant environments (e.g., different OS versions).
[ ] Confirm that all dependencies are up-to-date and compatible with the changes.