This PR addresses a bug when exporting action connectors, the required export details from the Kibana API were not provided. Now the flag appropriately informs the Kibana API call to include the necessary details to parse the action connectors separately from the rules.
How To Test
To test this, run the kibana export-rules command with the -ac flag without the -e flag. In prior tests, the Kibana export details were not provided and the parsing of the connectors would fail. Note you do not need rules with action connectors to test this as the parsing issue occurs with the Kibana response message details which will be provided regardless of whether or not you have exceptions or action connectors, but based on whether or not either of those flags are passed to the RuleResource.export_rules call.
Checklist
[ ] Added a label for the type of pr: bug, enhancement, schema, Rule: New, Rule: Deprecation, Rule: Tuning, Hunt: New, or Hunt: Tuning so guidelines can be generated
[ ] Added the meta:rapid-merge label if planning to merge within 24 hours
[ ] Secret and sensitive material has been managed correctly
[ ] Automated testing was updated or added to match the most common scenarios
[ ] Documentation and comments were added for features that require explanation
Pull Request
Issue link(s):
Summary - What I changed
This PR addresses a bug when exporting action connectors, the required export details from the Kibana API were not provided. Now the flag appropriately informs the Kibana API call to include the necessary details to parse the action connectors separately from the rules.
How To Test
To test this, run the
kibana export-rules
command with the-ac
flag without the-e
flag. In prior tests, the Kibana export details were not provided and the parsing of the connectors would fail. Note you do not need rules with action connectors to test this as the parsing issue occurs with the Kibana response message details which will be provided regardless of whether or not you have exceptions or action connectors, but based on whether or not either of those flags are passed to theRuleResource.export_rules
call.Checklist
bug
,enhancement
,schema
,Rule: New
,Rule: Deprecation
,Rule: Tuning
,Hunt: New
, orHunt: Tuning
so guidelines can be generatedmeta:rapid-merge
label if planning to merge within 24 hoursContributor checklist