Closed terrancedejesus closed 1 month ago
These guidelines serve as a reminder set of considerations when proposing a new rule.
creation_date
matches the date of creation PR initially merged.min_stack_version
should support the widest stack versions.name
and description
should be descriptive and not include typos.query
should be inclusive, not overly exclusive, considering performance for diverse environments. Non ecs fields should be added to non-ecs-schema.json
if not available in an integration.min_stack_comments
and min_stack_version
should be included if the rule is only compatible starting from a specific stack version.index
pattern should be neither too specific nor too vague, ensuring it accurately matches the relevant data stream (e.g., use logs-endpoint.process-* for process data).integration
should align with the index
. If the integration is newly introduced, ensure the manifest, schemas, and new_rule.yaml
template are updated.setup
should include the necessary steps to configure the integration.note
should include any additional information (e.g. Triage and analysis investigation guides, timeline templates).tags
should be relevant to the threat and align/added to the EXPECTED_RULE_TAGS
in the definitions.py file.threat
, techniques
, and subtechniques
should map to ATT&CK always if possible.building_block_type
should be included if the rule is a building block and the rule should be located in the rules_building_block
folder.bypass_bbr_timing
should be included if adding custom lookback timing to the rule.
Pull Request
Issue link(s):
Summary - What I changed
Added 2 new prebuilt OOTB detection rules for Microsoft 365 integration related to impossible travel activity. Also deprecated a rule as it is no longer applicable based on Defender changes to Microsoft 365 customers. Please see related issue for more details regarding this.
Note: While it is straight-forward to identify impossible travel, identifying valid account compromise at login regardless of time are a bit more challenging, therefore the New Terms rule has been added to at least alert when any new country is logged from. This logic could be adjusted to be more region or city focused, but to reduce noise, country was selected.
How To Test
Query has been tested to match login behavior. Rules are threshold and new terms in order to identify logins from 2 separate locations within a 15 minute window of eachother and any time an unusual region appears as the source for a user login.
Checklist
bug
,enhancement
,schema
,Rule: New
,Rule: Deprecation
,Rule: Tuning
,Hunt: New
, orHunt: Tuning
so guidelines can be generatedmeta:rapid-merge
label if planning to merge within 24 hoursContributor checklist