Docs for new logstash-filter-elastic_integration plugin are not being picked up for LSR

karenzone commented 10 months ago

We recently added support for plugins outside of the logstash-plugins GitHub org with #103.

Versioned Plugin Reference (VPR)

The VPR build is picking up changes as expected. ✅ Example: auto generated update picked up filter-elastic_integration v0.1.4

Logstash Reference (LSR)

The filter-elastic_integration content that is currently published was added manually (PR #1579) with the plan to have it update programmatically for future version bumps.
The plugin has been added to rakelib/plugins-metadata.json (PR #15692)
I generated plugin docs for main after filter-elastic_integration v9.1.4 came through for the VPR.
The v9.1.4 update didn't get picked up for the LSR. ❌

Published pages

Link to VPR page: https://www.elastic.co/guide/en/logstash-versioned-plugins/current/v0.1.4-plugins-filters-elastic_integration.html
Link to LSR page: https://www.elastic.co/guide/en/logstash/master/plugins-filters-elastic_integration.html

@mashhurs, thanks again for your great work on the docs tooling. It seems that we have one more kink to work out before this works seamlessly.

mashhurs commented 10 months ago

Hm, interesting. ./gradlew generatePluginsVersion somehow didn't include elastic_integration plugin in plugins_version_docs.json. I will investigate and fix this, assigning myself.

Thanks for catching this up!

karenzone commented 10 months ago

Fantastic! Thanks for your help with this, @mashhurs.

mashhurs commented 9 months ago

@karenzone this was covered when non-OSS feature was introduced. Sorry that I forgot to update here 🤦 I have just run the workflow to double check and it is here: I have https://github.com/elastic/logstash-docs/pull/1613/files#diff-d795e5afb754865b186622bfd833c211c013d0a49f7b8d050e06915dab87ffa3

karenzone commented 9 months ago

Awesome! Thanks for fixing this. Do you have a PR number we can link to this issue for future reference?

mashhurs commented 9 months ago

Awesome! Thanks for fixing this. Do you have a PR number we can link to this issue for future reference?

I'm going to delete my previous comment to avoid confusion. :-)

Here it is: https://github.com/elastic/logstash/pull/15769

karenzone commented 9 months ago

Fixed with merge of https://github.com/elastic/logstash/pull/15769

elastic / docs-tools