elastic / docs

21 stars 333 forks source link

feat(apm-*): only build docs if there's a doc change #3066

Closed kruskall closed 1 month ago

kruskall commented 1 month ago

extend the check to all apm repositories and use a switch to make it easier to add more repo that share common file patterns

as usual nothing changes for repositories not mentioned in the switch (they always build and no git diff is run)

github-actions[bot] commented 1 month ago

A documentation preview will be available soon.

Request a new doc build by commenting * Rebuild this PR: `run docs-build` * Rebuild this PR and all Elastic docs: `run docs-build rebuild` `run docs-build` is much faster than `run docs-build rebuild`. A `rebuild` should only be needed in rare situations. If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status [here](https://buildkite.com/elastic/docs-build).
bmorelli25 commented 1 month ago

Fantastic! I added comments to your code (mostly for myself) but also since this script is pretty well documented and I wanted to keep it that way. Based on your prior testing, I'm pretty confident this will work, but I'm going to wait until tomorrow morning (my tomorrow morning) to merge. That way if things go wrong I can revert ASAP.

Thank you!

kruskall commented 1 month ago

Thank you! :bow: