elastic / ecctl

Apache License 2.0
58 stars 53 forks source link

Expose clear transients in ecctl #649

Closed nick-benoit closed 6 months ago

nick-benoit commented 6 months ago

Description

Exposes new clear_transients field for ecctl for show deployment.

The default value depends on on the value of generate-update-payload in order to facilitate safe usage of the "read - edit - write" loop. If generate-update-payload=true then clear-transients also defaults to true and is false otherwise. If the flag is manually passed then that value takes precedence.

Related Issues

https://elasticco.atlassian.net/browse/CP-4726

Motivation and Context

This change makes reading and writing deployments safer. We ran into this during the last security remediation and almost overwrote someone’s cluster from their most recent snapsho

How Has This Been Tested?

This has been tested by using local build to operate against QA ESS. I have verified that with --generate-update-payload=true the transient properties are not included (default behavior). If --generate-update-payload=true and --clear-transient=false is explicitly passed then transient properties are included.

Types of Changes

Readiness Checklist