elastic / ecs-dotnet

https://www.elastic.co/guide/en/ecs-logging/dotnet/current/setup.html
Apache License 2.0
114 stars 58 forks source link

[BUG] useSniffing parameter is actually dontUseSniffing #342

Open kammerjaeger opened 10 months ago

kammerjaeger commented 10 months ago

ECS integration/library project(s) (e.g. Elastic.CommonSchema.Serilog): Elastic.Serilog.Sinks

ECS .NET assembly version (e.g. 1.4.2): 8.6.1

Description of the problem, including expected versus actual behavior: The parameter is the opposite of what its name is, that is quite confusing. See: https://github.com/elastic/ecs-dotnet/blob/eac06c3df532d33c1889cca7dca388216c945dc4/src/Elastic.Serilog.Sinks/ElasticsearchSinkExtensions.cs#L81

Possible solution: https://github.com/elastic/ecs-dotnet/commit/0f0f89448a702c0103eabd5e4cb55df299b40e13