search

elastic / ecs-dotnet

https://www.elastic.co/guide/en/ecs-logging/dotnet/current/setup.html
Apache License 2.0
117 stars 59 forks source link

NLog ElasticSearch Target #369

Closed snakefoot closed 5 months ago

snakefoot commented 6 months ago

NLog Target that exports directly to Elastic Cloud or individual Elasticsearch nodes

Docs Preview: https://github.com/snakefoot/ecs-dotnet/tree/main/src/Elastic.NLog.Targets

snakefoot commented 6 months ago

what a great addition to datashippers!

Yes was just missing a "Flush"-method on the shipper, as both NLog and log4net has the ability to "Flush" its targets/appenders. Flush-with-timeout gives a better shutdown experience, as dispose has no timeout, and will lead to mesage-loss when closing/disposing while burning down the house (timeout limited to 1-2 secs).

Could you address the conflict on the sln file?

Conflicts has been resolved

Mpdreamz commented 5 months ago

run docs-build

snakefoot commented 5 months ago

@Mpdreamz Hope I nailed the integration-test this time. Sorry about the retries.

Mpdreamz commented 5 months ago

run docs-build

Mpdreamz commented 5 months ago

@Mpdreamz Hope I nailed the integration-test this time. Sorry about the retries.

Don't be! I'll gladly retry until we get there, looking forward to releasing this!

snakefoot commented 5 months ago

And one more retry, please :)

Mpdreamz commented 5 months ago

run docs-build

snakefoot commented 5 months ago

Finally green build :)

Mpdreamz commented 5 months ago

run docs-build

Mpdreamz commented 5 months ago

@snakefoot thanks for this new package!

I will be out starting today for 10 days but will release this as soon as I am back, after looking at the other open PR.