search

elastic / ecs-dotnet

https://www.elastic.co/guide/en/ecs-logging/dotnet/current/setup.html
Apache License 2.0
108 stars 54 forks source link

[FEATURE] Include sequence id under event details #386

Closed thompson-tomo closed 1 month ago

thompson-tomo commented 2 months ago

ECS integration/library project(s) (e.g. Elastic.CommonSchema.Serilog): Elastic.CommonSchema.Nlog

Is your feature request related to a problem? Please describe. Enable clearly sequencing of logs

Describe the solution you'd like I would like the sequenceId which is available as part of the logevent to be recorded under my event as defined in the spec

Describe alternatives you've considered Rely on timestamps

Additional context Definition as per: https://www.elastic.co/guide/en/ecs/current/ecs-event.html#field-event-sequence

Mpdreamz commented 1 month ago

Opened https://github.com/elastic/ecs-dotnet/pull/392 to address this thanks @thompson-tomo

Mpdreamz commented 1 month ago

Closing this as won't fix since SequenceId will be deprecated

see https://github.com/elastic/ecs-dotnet/pull/392 for more discussions around this.

thompson-tomo commented 1 month ago

thanks @Mpdreamz i noticed in my testing/debugging when i instpected the logevent it was being incremented on each run through but if it is planned to be removed that is also ok.