elastic / ecs-logging-java

https://www.elastic.co/guide/en/ecs-logging/java/current/intro.html
Apache License 2.0
139 stars 74 forks source link

added layout #145

Closed dgempiuc closed 5 months ago

dgempiuc commented 2 years ago

layout field added and encode method modified by using the layout while adding the messages to the log file.

cla-checker-service[bot] commented 2 years ago

💚 CLA has been signed

apmmachine commented 2 years ago

:grey_exclamation: Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS Pipeline View Test View Changes Artifacts preview

Expand to view the summary

#### Build stats * Start Time: 2022-08-21T10:31:22.417+0000 * Duration: 3 min 0 sec

Steps errors 2

Expand to view the steps failures

##### `Load a resource file from a library`

  • Took 0 min 0 sec . View more details here
  • Description: approval-list/elastic/ecs-logging-java.yml
##### `Error signal`
  • Took 0 min 0 sec . View more details here
  • Description: githubApiCall: The REST API call https://api.github.com/orgs/elastic/members/dgempiuc return the message : java.lang.Exception: httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/dgempiuc : httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/dgempiuc : Code: 404Error: {"message":"User does not exist or is not a member of the organization","documentation_url":"https://docs.github.com/rest/reference/orgs#check-organization-membership-for-a-user"}

:robot: GitHub comments

To re-run your PR in the CI, just comment with:

fapena-galileo commented 2 years ago

Any news on this PR? It would be very useful to be able to configure the layout to customize the message.

felixbarny commented 2 years ago

@felixbarny any reason you see for not adding it?

No objections but it would be interesting to know about the use case this solves. Why would you want to use a layout within the message field?

rdifrango commented 1 year ago

@felixbarny the reason for needing this is covered by #144, basically being able to mask fields in environments where you are handling sensitive data would be good to have in this encoder.

If @dgempiuc can't update this PR to get it merged, I would be willing to contribute this as well.

felixbarny commented 1 year ago

If @dgempiuc can't update this PR to get it merged, I would be willing to contribute this as well.

SGTM. But please be sure to take his commits as the foundation so that he still appears as a co-author of your PR.

maxiking445 commented 1 year ago

@felixbarny the reason for needing this is covered by #144, basically being able to mask fields in environments where you are handling sensitive data would be good to have in this encoder.

If @dgempiuc can't update this PR to get it merged, I would be willing to contribute this as well.

Any news here? @rdifrango

rdifrango commented 1 year ago

@maxiking445 Unfortunately, I haven't had time to get back to it...I had it staged and started the proposed changes but haven't yet finished them :(

rdifrango commented 7 months ago

@maxiking445 I'm working through the process now to contribute this back. It'll likely be in the form of a new PR with the commits from @dgempiuc as the base.

rdifrango commented 6 months ago

Replaced by #220

rdifrango commented 5 months ago

@JonasKunz now that #220 is merged we should go ahead and close this one as it supersedes it.