Closed dgempiuc closed 5 months ago
💚 CLA has been signed
The PR is not allowed to run in the CI yet
the below badges are clickable and redirect to their specific view in the CI or DOCS
#### Build stats * Start Time: 2022-08-21T10:31:22.417+0000 * Duration: 3 min 0 sec
##### `Load a resource file from a library`
approval-list/elastic/ecs-logging-java.yml
githubApiCall: The REST API call https://api.github.com/orgs/elastic/members/dgempiuc return the message : java.lang.Exception: httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/dgempiuc : httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/dgempiuc : Code: 404Error: {"message":"User does not exist or is not a member of the organization","documentation_url":"https://docs.github.com/rest/reference/orgs#check-organization-membership-for-a-user"}
To re-run your PR in the CI, just comment with:
/test
: Re-trigger the build.
run
elasticsearch-ci/docs
: Re-trigger the docs validation. (use unformatted text in the comment!)
Any news on this PR? It would be very useful to be able to configure the layout to customize the message.
@felixbarny any reason you see for not adding it?
No objections but it would be interesting to know about the use case this solves. Why would you want to use a layout within the message
field?
@felixbarny the reason for needing this is covered by #144, basically being able to mask fields in environments where you are handling sensitive data would be good to have in this encoder.
If @dgempiuc can't update this PR to get it merged, I would be willing to contribute this as well.
If @dgempiuc can't update this PR to get it merged, I would be willing to contribute this as well.
SGTM. But please be sure to take his commits as the foundation so that he still appears as a co-author of your PR.
@felixbarny the reason for needing this is covered by #144, basically being able to mask fields in environments where you are handling sensitive data would be good to have in this encoder.
If @dgempiuc can't update this PR to get it merged, I would be willing to contribute this as well.
Any news here? @rdifrango
@maxiking445 Unfortunately, I haven't had time to get back to it...I had it staged and started the proposed changes but haven't yet finished them :(
@maxiking445 I'm working through the process now to contribute this back. It'll likely be in the form of a new PR with the commits from @dgempiuc as the base.
Replaced by #220
@JonasKunz now that #220 is merged we should go ahead and close this one as it supersedes it.
layout field added and encode method modified by using the layout while adding the messages to the log file.