Add support for service.environment

elastic / ecs-logging-java

https://www.elastic.co/guide/en/ecs-logging/java/current/intro.html

Apache License 2.0

141 stars 75 forks source link

Add support for service.environment #184

Closed odin568 closed 2 years ago

odin568 commented 2 years ago

As an extension of elastic/ecs-logging-java#168 We are hosting different environments of our applications, i.e. dev, test and of course prod. In order to distinguish logs, we set the service.environment field. With this change it is easier to achieve. Please review and feel free to merge.

cla-checker-service[bot] commented 2 years ago

💚 CLA has been signed

apmmachine commented 2 years ago

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

#### Build stats * Start Time: 2022-05-02T08:07:44.403+0000 * Duration: 7 min 47 sec #### Test stats :test_tube: | Test | Results | | ------------ | :-----------------------------: | | Failed | 0 | | Passed | 243 | | Skipped | 0 | | Total | 243 |

:robot: GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

felixbarny commented 2 years ago

@odin568 thanks for your contribution! This makes a lot of sense to me. Please make sure to sign the CLA so that we are able to merge the PR.

odin568 commented 2 years ago

@odin568 thanks for your contribution! This makes a lot of sense to me. Please make sure to sign the CLA so that we are able to merge the PR.

Hi, yes I tried. Seems to be more complex than the change. Not sure if I submitted multiple times, did not get any mail, etc. so far. Sorry for inconvenience then ;)

felixbarny commented 2 years ago

Please make sure that the email address you're using to sign the CLA is also registered in your GitHub settings (https://github.com/settings/emails).

odin568 commented 2 years ago

Please make sure that the email address you're using to sign the CLA is also registered in your GitHub settings (https://github.com/settings/emails).

Valid Point. I re-signed it, no Mail so far.

felixbarny commented 2 years ago

I can see you in the system with two different email addresses now. However, the mail used in your git config (see https://github.com/elastic/ecs-logging-java/pull/184.patch) is a different one.

odin568 commented 2 years ago

I can see you in the system with two different email addresses now. However, the mail used in your git config (see https://github.com/elastic/ecs-logging-java/pull/184.patch) is a different one.

Allright, now you should have three :) Sorry, too many different workstations

eyalkoren commented 2 years ago

/test

odin568 commented 2 years ago

I applied changes you mentioned. Thanks for feedback!