elastic / ecs-logging-nodejs

https://www.elastic.co/guide/en/ecs-logging/nodejs/master/intro.html
Apache License 2.0
68 stars 39 forks source link

feat: add morgan types to work with typescript #119

Closed floross closed 1 year ago

floross commented 2 years ago

This pull request add types information to the morgan elastic package (@elastic/ecs-morgan-format)

cla-checker-service[bot] commented 2 years ago

❌ Author of the following commits did not sign a Contributor Agreement: 3716ad9d0473e7f6595e158c3fe410e1148d847d

Please, read and sign the above mentioned agreement if you want to contribute to this project

apmmachine commented 2 years ago

:grey_exclamation: Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS Pipeline View Test View Changes Artifacts preview

Expand to view the summary

#### Build stats * Start Time: 2022-05-03T13:37:50.455+0000 * Duration: 3 min 59 sec

Steps errors 1

Expand to view the steps failures

##### `Error signal`

  • Took 0 min 0 sec . View more details here
  • Description: githubApiCall: The REST API call https://api.github.com/orgs/elastic/members/floross return the message : java.lang.Exception: httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/floross : httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/floross : Code: 404Error: {"message":"User does not exist or is not a member of the organization","documentation_url":"https://docs.github.com/rest/reference/orgs#check-organization-membership-for-a-user"}

:robot: GitHub comments

To re-run your PR in the CI, just comment with:

trentm commented 1 year ago

Hi @floross. Thanks very much for your PR! I'm sorry that I didn't get back to you way back when you submitted this. Are you able to sign our CLA (at https://www.elastic.co/contributor-agreement)? Then I'll be able to get this in this week.