search

elastic / ecs-logging-php

Apache License 2.0
19 stars 35 forks source link

Release? #16

Open DRoet opened 4 years ago

DRoet commented 4 years ago

The readme lists support for monolog v2 but the latest version on packagist (elastic/ecs-logging) is an older version (1.0.1) that is not synced up with the instructions in this repo.

Maybe release an alpha/beta so its less confusing? right now it's not clear you will have to pull the repo using "dev-master'

TSchuermans commented 4 years ago

I think you're mixing monolog up with psr/log

DRoet commented 4 years ago

Apologies, I just realised the older 1.0.1 release does work with monolog v2. I was talking about the v2 namespace changes introduced in January, see commit https://github.com/elastic/ecs-logging-php/commit/b0e438a96ed04d553fe418299cd47b326772e674 and https://github.com/elastic/ecs-logging-php/commit/62f2b60fd2cf3e2451ba06b15b0bfd9c41dd1699 that changes how the library works.

If people follow the instructions in the readme it will not work with the older 1.0.1 version which can be confusing.

SergeyKleyman commented 3 years ago

In the latest release (1.0.2) we decided to revert v2 namespace changes and stay with Monolog version neutral namespace for now - if it will be necessary it should be possible to add support for Monolog v1 by detecting Monolog version at runtime i.e., without requiring changes to the part of the application referring to ElasticCommonSchemaFormatter. As a bonus 1.0.2 is backward compatible with already existing 1.* releases (as it should be). The online docs are in sync as well.