search

elastic / ecs-logging-php

Apache License 2.0
19 stars 35 forks source link

Enabled the library to be installed for PHP 8.0 #31

Closed pimjansen closed 3 years ago

pimjansen commented 3 years ago

This change will allow users to install the lib for PHP 8 environments as referenced in bug #30

cla-checker-service[bot] commented 3 years ago

❌ Author of the following commits did not sign a Contributor Agreement: e2c75d3e53a492389a094b9d68a9565cc5be0bd6

Please, read and sign the above mentioned agreement if you want to contribute to this project

pimjansen commented 3 years ago

The agreement was actually signed already. Did it a second time now. No idea what it does not know why.

apmmachine commented 3 years ago

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS Pipeline View Test View Changes Artifacts preview

Expand to view the summary

#### Build stats * Build Cause: `Started by user Sergey Kleyman` * Start Time: 2021-04-29T13:58:07.720+0000 * Duration: 7 min 1 sec * Commit: e2c75d3e53a492389a094b9d68a9565cc5be0bd6 #### Test stats :test_tube: | Test | Results | | ------------ | :-----------------------------: | | Failed | 0 | | Passed | 84 | | Skipped | 0 | | Total | 84 | #### Trends :test_tube: ![Image of Build Times](https://apm-ci.elastic.co/job/apm-agent-php/job/ecs-logging-php-mbp/job/PR-31/buildTimeGraph/png) ![Image of Tests](https://apm-ci.elastic.co/job/apm-agent-php/job/ecs-logging-php-mbp/job/PR-31/2/testReport/history/countGraph/png?start=0&end=25)

SergeyKleyman commented 3 years ago

The agreement was actually signed already. Did it a second time now. No idea what it does not know why.

@pimjansen Unfortunately you used different emails for commit and when signing CLA. You can either sign a new CLA with the matching email address, or amend your commit and force-push to their PR branch (or close and make a new PR) - https://stackoverflow.com/questions/3042437/how-to-change-the-commit-author-for-one-specific-commit