elastic / ecs-logging

ECS Logging - Common resources and issues for the language specific ECS loggers
https://www.elastic.co/guide/en/ecs-logging/overview/master/intro.html
Apache License 2.0
41 stars 15 forks source link

Ensure ecs.version is treated as a top level field #71

Closed Mpdreamz closed 1 year ago

Mpdreamz commented 1 year ago

This ensures the ecs.version is always written as top level field without arbitrary nesting it.

This aligns the spec closer to the written documentation:

https://github.com/elastic/ecs-logging/tree/main/spec#minimum-viable-product

apmmachine commented 1 year ago

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

#### Build stats * Start Time: 2023-01-18T15:35:09.538+0000 * Duration: 3 min 58 sec

trentm commented 1 year ago

Note (to self, I guess): I'll have to change the node.js ecs-logging libs to do this. Currently they are written log records like this:

{"log.level":"debug","@timestamp":"2023-01-19T17:51:47.649Z","log":{"logger":"elastic-apm-node"},"ecs":{"version":"1.6.0"},"message":"..."}
basepi commented 1 year ago

Yeah, python only does this with log.level right now, iirc.

apmmachine commented 1 year ago

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

#### Build stats * Start Time: 2023-01-20T04:38:00.032+0000 * Duration: 6 min 30 sec

apmmachine commented 1 year ago

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

#### Build stats * Start Time: 2023-01-23T04:38:00.031+0000 * Duration: 7 min 33 sec

Mpdreamz commented 1 year ago

Thanks for the reviews! Merging now.