Open ebeahan opened 1 month ago
I am on board with making data_stream.namespace
more permissive in order to not introduce breaking changes in existing implementations.
However, as a counter argument, allowing -
in data_stream.namespace makes it a bit tricky to come up with correct index patterns in some edge cases. I'm not sure if that's considered yet.
For example, let's say we have 2 data streams, one called metrics-generic.otel-default
, another DS metrics-generic-my.otel-ns
where namespace is my.otel-ns
. They will both match metrics-*.otel-*
index pattern, which may cause some index templates to be applied unintentionally.
cc @felixbarny
I don't see the risk of that being fundamentally different to metrics-*.otel-*
matching datasets that happen to end with .otel
(for example metrics-apm.app.myservice.otel-default
) but aren't actually in the OTel native format.
Summary
Propose ECS removes the restriction of using the dash character,
-
, in thedata_stream.namespace
field.Motivation:
RFC 0009 - Data stream fields includes this restrictions for the
data_stream.namespace
field:The current description for
data_stream.namespace
also restricts using the dash character:Suspect these restrictions may have been mistakenly copied from the same restriction on
data_stream.type
anddata_stream.dataset
.I would not consider the change breaking. It makes
data_stream.namespace
more permissive and thedata_stream.*
field set is still considered beta.