Add TQDM progress bar for Jupyter Notebook pandas_to_eland() calls - Githubissues

elastic / eland

Python Client and Toolkit for DataFrames, Big Data, Machine Learning and ETL in Elasticsearch

https://eland.readthedocs.io

Apache License 2.0

636 stars 98 forks source link

Add TQDM progress bar for Jupyter Notebook pandas_to_eland() calls #294

Open sethmlarson opened 3 years ago

sethmlarson commented 3 years ago

https://github.com/tqdm/tqdm#ipythonjupyter-integration
Units are rows/s
Maybe hide progress bar on completion? Need to test it out first.
Add an option show_progressbar which defaults to None
- If None show a progress bar only if we detect Jupyter Notebook
- If False don't show a progress bar
- If True show a progress bar only if we detect Jupyter Notebook (for now)

V1NAY8 commented 3 years ago

I'll try to implement this and get a gif to show for you. 😬

V1NAY8 commented 3 years ago

@sethmlarson I tried an example in jupyter notebook

ezgif com-gif-maker

Need suggestion on this:

from tqdm.notebook import tqdm => It only works in jupyter notebook , not in jupyter lab, terminal

In jupyter lab, It throws the following:

I had the same scenario for from tqdm.auto import tqdm

Looks like there's already an issue in tqdm

Still currently exploring different options of tqdm 😄

My Queries are:

Is it Ok, If we just do for jupyter notebook ?
For testing this, Should I go with pytest --nbval to match the output?