elastic / eland

Python Client and Toolkit for DataFrames, Big Data, Machine Learning and ETL in Elasticsearch
https://eland.readthedocs.io
Apache License 2.0
18 stars 98 forks source link

Apply black to comply with the code style #557

Closed sakurai-youhei closed 1 year ago

sakurai-youhei commented 1 year ago

Relates https://github.com/elastic/eland/pull/552

Issue:

C:\Users\YouheiSakurai\git\myeland>python -m black --version
python -m black, 23.3.0 (compiled: yes)
Python (CPython) 3.11.0

C:\Users\YouheiSakurai\git\myeland>python -m black --check --target-version=py38 bin\eland_import_hub_model
would reformat bin\eland_import_hub_model

Oh no! 💥 💔 💥
1 file would be reformatted.

Solution:

C:\Users\YouheiSakurai\git\myeland>python -m black --target-version=py38 bin\eland_import_hub_model
reformatted bin\eland_import_hub_model

All done! ✨ 🍰 ✨
1 file reformatted.
sakurai-youhei commented 1 year ago

@valeriy42 Unlike shell, bin/* doesn't seem to be extracted by nox. Should I put bin/eland_import_hub_model instead?

By the way, I'm planning to move the eland_import_hub_model out of bin/ in the next PR to solve https://github.com/elastic/eland/issues/551, so would you agree to leave bin/ as it is alternatively?

valeriy42 commented 1 year ago

@valeriy42 Unlike shell, bin/* doesn't seem to be extracted by nox. Should I put bin/eland_import_hub_model instead?

Interesting. It seems that the behavior on Mac and Linux is different.

sakurai-youhei commented 1 year ago

@valeriy42 Once merged, I will start working on the next PR and ensure the file to be moved will be covered by the noxfile accordingly. Thanks!