Closed sakurai-youhei closed 1 year ago
As response to https://github.com/elastic/eland/pull/557#pullrequestreview-1525783718:
The following flake8 lint errors proves that noxfile covers eland/cli/eland_import_hub_model.py
properly.
https://github.com/elastic/eland/actions/runs/5540963903/jobs/10113737631?pr=559
I've tested this change on macOS and the script is installed into the exact same location as before, i.e. /Library/Frameworks/Python.framework/Versions/3.X/bin/eland_import_hub_model
@sakurai-youhei The build system is being migrated from Jenkins to Buildkite and there are problems which is why your PR is not passing CI. The PR did pass the CI checks previously, I've tested the change and it is good. The CI failure is nothing to do with your change so I will merge the PR and users can benefit from your change.
Thanks more making the eland_import_hub_model
script easier to user.
Closes #551.
With this PR,
eland_import_hub_model
gets easier to find on Windows.On windows:
eland_import_hub_model
is an executable file.On Linux:
eland_import_hub_model
is a simple auto-generated script file.Note: Because I come to think adding
python -m eland
would be too ambicious, I dropped it from the scope.