search

elastic / eland

Python Client and Toolkit for DataFrames, Big Data, Machine Learning and ETL in Elasticsearch
https://eland.readthedocs.io
Apache License 2.0
635 stars 98 forks source link

Remove deprecated check_less_precise #596

Closed bartbroere closed 11 months ago

bartbroere commented 12 months ago

This removes the deprecated check_less_precise argument from one of the unit tests.

Part of the necessary adjustments to maybe start supporting pandas>=2.0.0

bartbroere commented 11 months ago

Do we also need to specify check_exact=False? According to the 2.0 docs, rtol is defined as:

Relative tolerance. Only used when check_exact is False.

Good catch! I'll update it.

bartbroere commented 11 months ago

Do we also need to specify check_exact=False? According to the 2.0 docs, rtol is defined as:

Relative tolerance. Only used when check_exact is False.

Do we also need to specify check_exact=False? According to the 2.0 docs, rtol is defined as:

Relative tolerance. Only used when check_exact is False.

Good catch! I'll update it.

@pquentin I added the check_exact=False flag, but Github still doesn't think I "addressed the requested changes". Not sure how that works, but I think it's all good now.

pquentin commented 11 months ago

buildkite test this please