search

elastic / eland

Python Client and Toolkit for DataFrames, Big Data, Machine Learning and ETL in Elasticsearch
https://eland.readthedocs.io
Apache License 2.0
628 stars 98 forks source link

Fix colab link #632

Closed leemthompo closed 8 months ago

leemthompo commented 8 months ago

The Colab button doesn't work in readthedocs, so just using standard markdown link format.

pquentin commented 8 months ago

@leemthompo Since the "Open in Colab" image is so recognizable, I restored it using the Markdown image syntax + the link syntax. What do you think? https://eland--632.org.readthedocs.build/en/632/examples/demo_notebook.html

leemthompo commented 8 months ago

@pquentin Perfect LGTM! 🪄

Unrelated, but I found a weirdness where latest doesn't map to v8.11.x on site.

https://eland.readthedocs.io/en/v8.11.0/examples/demo_notebook.html

versus

https://eland.readthedocs.io/en/latest/examples/demo_notebook.html

pquentin commented 8 months ago

Unrelated, but I found a weirdness where latest doesn't map to v8.11.x on site.

latest include the latest commits to main. Your notebook fix landed just after the 8.11.0 release, which is why it isn't there. Does that make sense?

pquentin commented 8 months ago

Can you please give me a formal approval on GitHub? I can't approve as I wrote the last commit.

leemthompo commented 8 months ago

@pquentin I can't approve my own PR 😄

pquentin commented 8 months ago

Hmm indeed my approval was enough. Interesting. Sorry about the noise!

leemthompo commented 8 months ago

latest include the latest commits to main. Your notebook fix landed just after the 8.11.0 release, which is why it isn't there. Does that make sense?

Sure does. Wonder if it would be nice to be able to backport docs stuff?