elastic / eland

Python Client and Toolkit for DataFrames, Big Data, Machine Learning and ETL in Elasticsearch
https://eland.readthedocs.io
Apache License 2.0
640 stars 98 forks source link

Fix missing value support for XGBRanker. #654

Closed afoucret closed 8 months ago

afoucret commented 8 months ago

When exporting XGBoost trees to ES, it was assumed are always using the left branch of the tree. In fact it is false and it is needed to configure it using a conditional on default_left.

Tests have been updated to check predicted score in _search match the one from the ranker model. It should allows us to catch any problem like this in the future.