Stop duplicating requirements

elastic / eland

Python Client and Toolkit for DataFrames, Big Data, Machine Learning and ETL in Elasticsearch

https://eland.readthedocs.io

Apache License 2.0

21 stars 99 forks source link

Stop duplicating requirements #691

Closed pquentin closed 6 months ago

pquentin commented 6 months ago

Today we specify elasticsearch>=8.3,<9 in four places. In setup.py, as expected for the package metadata to be correct, but also:

in requirements.txt, which was unused, so I removed it
in requirements-dev.txt, which can simply refer to .[extras] to install all packages with its extras
in noxfile.py, where installing . is enough to make lint pass (also we don't need pre-releases anymore)
in docs/requirements-docs.txt which was out of date anyway

pquentin commented 6 months ago

Thanks for looking. I don't understand how that is relevant to that pull request though. On main requirements-dev.txt also contains lightgbm. If you don't want it, it is easier to edit it out with this pull request since it's only in setup.py.

davidkyle commented 6 months ago

I now realised I can install Eland with the PyTorch dependencies but without LightGBM by running

python -m pip install .[pytorch]

That, essentially what I was asking for and its existed for a very long time but I didn't realise so I had a hacky workaround involving requirements.txt.

Thanks for cleaning up the install config.