Deal with the possibility of lists in multi-fields

elastic / eland

Python Client and Toolkit for DataFrames, Big Data, Machine Learning and ETL in Elasticsearch

https://eland.readthedocs.io

Apache License 2.0

21 stars 99 forks source link

Deal with the possibility of lists in multi-fields #707

Closed bartbroere closed 4 months ago

bartbroere commented 4 months ago

While running the new release, it looks like my previous pull request #693 didn't deal with an edge case while checking whether a field was present. It is possible for a field to be a list of dicts as well.

On top of that it feels a bit like painting myself into a corner fixing the missing fields #692. The example indices eland uses for testing aren't as complex (and nested) as the mappings I'm dealing with in our internal data warehouse.

pquentin commented 4 months ago

buildkite test this please

pquentin commented 4 months ago

The complexity is unfortunate but we don't have much choice here.